Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add support for handling file extensions in load_from_tsfile #1953

Merged
merged 4 commits into from
Aug 13, 2024
Merged

[ENH] Add support for handling file extensions in load_from_tsfile #1953

merged 4 commits into from
Aug 13, 2024

Conversation

Sharathchenna
Copy link
Contributor

@Sharathchenna Sharathchenna commented Aug 12, 2024

What does this implement/fix? Explain your changes.
I made changes in the data_loaders.py to check the extension of the file. If an extension is already like .txt, it will not append .ts. If there is no extension, it will append .ts extension

resolves #1922

@aeon-actions-bot aeon-actions-bot bot added the datasets Datasets and data loaders label Aug 12, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#0B1D38}{\textsf{datasets}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@Sharathchenna
Copy link
Contributor Author

@MatthewMiddlehurst Hey! Hello can you please check into this code because i ran pre-commit command and made some changes but the test is still failing . Thanks!

Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it solve the issue, thanks for contributing !
I'll leave the merging to @TonyBagnall so he can confirm that's what he wanted.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for that

@TonyBagnall TonyBagnall changed the title Add support for handling file extensions in load_from_tsfile [ENH] Add support for handling file extensions in load_from_tsfile Aug 13, 2024
@TonyBagnall
Copy link
Contributor

@all-contributors add @Sharathchenna for code

Copy link
Contributor

@TonyBagnall

I've put up a pull request to add @Sharathchenna! 🎉

@TonyBagnall TonyBagnall merged commit 338021e into aeon-toolkit:main Aug 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Datasets and data loaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] input to load_from_tsfile
4 participants