-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add support for handling file extensions in load_from_tsfile #1953
Conversation
Thank you for contributing to
|
@MatthewMiddlehurst Hey! Hello can you please check into this code because i ran pre-commit command and made some changes but the test is still failing . Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it solve the issue, thanks for contributing !
I'll leave the merging to @TonyBagnall so he can confirm that's what he wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks for that
@all-contributors add @Sharathchenna for code |
I've put up a pull request to add @Sharathchenna! 🎉 |
What does this implement/fix? Explain your changes.
I made changes in the data_loaders.py to check the extension of the file. If an extension is already like .txt, it will not append .ts. If there is no extension, it will append .ts extension
resolves #1922