Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] switch paa tests to use numpy #199

Merged
merged 22 commits into from
Mar 18, 2023
Merged

[ENH] switch paa tests to use numpy #199

merged 22 commits into from
Mar 18, 2023

Conversation

TonyBagnall
Copy link
Contributor

another small change, make the tests of PAA use numpy arrays instead of data frames

@TonyBagnall
remove RimeSeriesSVC
89a0a3c
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
c3f6f55
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
72d5a43
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
9ab91e9
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
dfcf5c6
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
a5d86e7
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
9479d04
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
5bd70de
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
b420359
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
a0f88a9
@TonyBagnall
Merge branch 'main' of https://github.com/scikit-time/scikit-time
e57e173
@TonyBagnall
Merge branch 'main' of https://github.com/aeon-toolkit/aeon
6af17f5
@TonyBagnall
Merge branch 'main' of https://github.com/aeon-toolkit/aeon
4f921fc
@TonyBagnall
Merge branch 'main' of https://github.com/aeon-toolkit/aeon
1c270f4
@TonyBagnall
Merge branch 'main' of https://github.com/aeon-toolkit/aeon
d2877c8
@TonyBagnall
Merge branch 'main' of https://github.com/aeon-toolkit/aeon
ba2e928
@TonyBagnall
Merge branch 'main' of https://github.com/aeon-toolkit/aeon
de409db
@TonyBagnall
change paa tests to use numpy
02c3c6d
@TonyBagnall
revert setup
6c6bf0f
@TonyBagnall TonyBagnall added transformations Transformations package testing Testing related issue or pull request labels Mar 14, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@patrickzib
Copy link
Contributor

Looks good to me. But can you remove the forecasting notebook?

@TonyBagnall
Copy link
Contributor Author

that bloody notebook is following me around! I'll replace it with the one from main

@TonyBagnall TonyBagnall requested a review from patrickzib March 15, 2023 20:28
@TonyBagnall
Copy link
Contributor Author

Looks good to me. But can you remove the forecasting notebook?

@patrickzib so I deleted it, copied it from main and pushed it, but it is still showing changes. No idea

GuzalBulatova
GuzalBulatova approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Every time I see nested arrays, a reference to Inception comes to mind, it's a dream inside of a dream inside of a dream... :)

@GuzalBulatova
Copy link
Contributor

GuzalBulatova commented Mar 17, 2023 •
edited
Loading

Looks good to me. But can you remove the forecasting notebook?

@patrickzib so I deleted it, copied it from main and pushed it, but it is still showing changes. No idea

Looks like there are just a bunch of spaces removed, can a pre-hook be a culprit? Although why would it run on a notebook that was reverted, curious.

patrickzib
patrickzib approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TonyBagnall TonyBagnall merged commit 5178d35 into main Mar 18, 2023
@TonyBagnall TonyBagnall deleted the test_paa branch March 18, 2023 08:39
@hadifawaz1999 hadifawaz1999 mentioned this pull request May 15, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickzib patrickzib patrickzib approved these changes

@GuzalBulatova GuzalBulatova GuzalBulatova approved these changes

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
testing Testing related issue or pull request transformations Transformations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TonyBagnall @patrickzib @GuzalBulatova