Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Removed reference to supervised regression notebook #2064

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[DOC] Removed reference to supervised regression notebook #2064

merged 2 commits into from
Sep 16, 2024

Conversation

danielroberts20
Copy link
Contributor

@danielroberts20 danielroberts20 commented Sep 16, 2024

Reference Issues/PRs

Fixes #2063

What does this implement/fix? Explain your changes.

Removes the reference to a separate notebook on supervised regression (TSFR) as per the advice of @TonyBagnall.

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

This is my first contribution to aeon and to any open-source software, with the aim of seeing what the process of contributing looks like.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added documentation Improvements or additions to documentation examples Example notebook related labels Sep 16, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#F3B9F8}{\textsf{documentation}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@danielroberts20
Copy link
Contributor Author

@all-contributors please add @danielroberts20 for doc

Copy link
Contributor

@danielroberts20

I've put up a pull request to add @danielroberts20! 🎉

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whats going on with pre-commit!

@TonyBagnall TonyBagnall self-requested a review September 16, 2024 17:59
@danielroberts20 danielroberts20 marked this pull request as ready for review September 16, 2024 18:04
@TonyBagnall TonyBagnall merged commit 3a35cb5 into aeon-toolkit:main Sep 16, 2024
3 checks passed
@danielroberts20 danielroberts20 deleted the danielroberts20-patch-2063 branch September 16, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples Example notebook related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Link for forecasting notebook is off
2 participants