-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fixed Bug for negative values for scatter plot #2364
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Reference Issues/PRs
Fixes #2270
What does this implement/fix? Explain your changes.
Scaling of the minimum and maximum values by 0.97 and 1.03 is intended to provide a padding around the data range. However, if the data includes negative values (like -0.324397), the scaled minimum (min_value) will be closer to zero when multiplied by 0.97 thereby making it removing itself from the plot range. Therefore to resolve this we can multiply the negative values by 1.05 for min_values and 0.95 for max_values thereby making all points visible in the plot
Result:

Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access