Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add LITETimeClassifier Example to Classification Notebook #2419

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

sumana-2705
Copy link

@sumana-2705 sumana-2705 commented Dec 1, 2024

Reference Issues/PRs

Fixes #2295

What does this implement/fix? Explain your changes.

Added LITETimeClassifier example to the classification.ipynb file in the examples section, demonstrating its application to arrow_head dataset

Does your contribution introduce a new dependency? If yes, which one?

No, this contribution does not introduce any new dependencies.

Any other comments?

Please let me know if any further adjustments or enhancements are needed for the example. I am attaching the image of the cells I have changed below. Thank you for reviewing!

Screenshot 2024-12-02 120907

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related labels Dec 1, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@sumana-2705
Copy link
Author

@all-contributors please add @sumana-2705 for code

Copy link
Contributor

@sumana-2705

I've put up a pull request to add @sumana-2705! 🎉

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, just a small comment in the notebook, @MatthewMiddlehurst would like your input as well

@MatthewMiddlehurst
Copy link
Member

Addition looks fine assuming it is fast to run, could you give a general idea on how long the cell takes for you to process?

Would also update the "Background info and references for classifiers used here" section.

@sumana-2705
Copy link
Author

Addition looks fine assuming it is fast to run, could you give a general idea on how long the cell takes for you to process?

Would also update the "Background info and references for classifiers used here" section.

I have updated the classifier description to include runtime information and references. In a Colab environment, it took approximately 6 minutes to run.

@MatthewMiddlehurst
Copy link
Member

That is too much unfortunately. This is obviously dependant on setup, but I would prefer around 10 seconds. The runtime is pretty long on our CI https://github.com/aeon-toolkit/aeon/actions/runs/12163243307/job/33921975615?pr=2419#step:6:741.

@sumana-2705
Copy link
Author

It is getting reduced by reducing number of epochs, but accuracy is decreasing. 50 epchs is returning 0.35 accuracy by with 1 min of runtime, 100 epochs is returning 0.59 accuracy with 2 mins of runtime, 200 epochs is returning 0.86 accuracy with 3 mins of runtime. What should I prefer now, should I reduce epochs to reduce runtime, can you please suggest me?

@hadifawaz1999
Copy link
Member

its okay if the number of epochs is small, you can add a comment that to really see the performance of deep learning in aeon you should use the default number of epochs, and that its reduced in this notebook for simplicity, put like 10 eoichs

@sumana-2705
Copy link
Author

@MatthewMiddlehurst @hadifawaz1999

I have made the all required changes, if it seems okay can you please merge this PR?

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much time does the cell take to run now?

@sumana-2705
Copy link
Author

Hello @hadifawaz1999

Can you please approve the changes and merge the PR if PR looks right, so that I can start workingon other issues. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Adding deep learning examples to Classification notebook
3 participants