-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add LITETimeClassifier Example to Classification Notebook #2419
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
@all-contributors please add @sumana-2705 for code |
I've put up a pull request to add @sumana-2705! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, just a small comment in the notebook, @MatthewMiddlehurst would like your input as well
Addition looks fine assuming it is fast to run, could you give a general idea on how long the cell takes for you to process? Would also update the "Background info and references for classifiers used here" section. |
I have updated the classifier description to include runtime information and references. In a Colab environment, it took approximately 6 minutes to run. |
That is too much unfortunately. This is obviously dependant on setup, but I would prefer around 10 seconds. The runtime is pretty long on our CI https://github.com/aeon-toolkit/aeon/actions/runs/12163243307/job/33921975615?pr=2419#step:6:741. |
It is getting reduced by reducing number of epochs, but accuracy is decreasing. 50 epchs is returning 0.35 accuracy by with 1 min of runtime, 100 epochs is returning 0.59 accuracy with 2 mins of runtime, 200 epochs is returning 0.86 accuracy with 3 mins of runtime. What should I prefer now, should I reduce epochs to reduce runtime, can you please suggest me? |
its okay if the number of epochs is small, you can add a comment that to really see the performance of deep learning in aeon you should use the default number of epochs, and that its reduced in this notebook for simplicity, put like 10 eoichs |
@MatthewMiddlehurst @hadifawaz1999 I have made the all required changes, if it seems okay can you please merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how much time does the cell take to run now?
Hello @hadifawaz1999 Can you please approve the changes and merge the PR if PR looks right, so that I can start workingon other issues. Thank you |
Reference Issues/PRs
Fixes #2295
What does this implement/fix? Explain your changes.
Added LITETimeClassifier example to the
classification.ipynb
file in the examples section, demonstrating its application toarrow_head
datasetDoes your contribution introduce a new dependency? If yes, which one?
No, this contribution does not introduce any new dependencies.
Any other comments?
Please let me know if any further adjustments or enhancements are needed for the example. I am attaching the image of the cells I have changed below. Thank you for reviewing!
PR checklist
For all contributions