-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] fix links in estimator overview page #2479
base: main
Are you sure you want to change the base?
Conversation
- rename `/aeon/classification/_dummy.py` file for `all_estimators` function to properly get it's path - as a result, the link for `DummyClassifier` get's corrected in the **Estimator Overview** page
Thank you for contributing to
|
The problem with the last class is that it's documentation doesn't exist whatsoever. One fix would be changing the folder structure, I'm not sure though. Thank you! |
Reference Issues/PRs
Fixes #2474
What does this implement/fix? Explain your changes.
This pull request fixes the incorrect links in the Overview Estimator page in the documentations.
The issue was that the
all_estimators
function from theaeon.utils.discovery
module wasn't providing correct path to those classes mentioned in #2474 (comment)It turned out, that the those classes generally don't have a
**underscore**
in front of their file names. It's because they're not part of a sub module.For example, the
DummyClassifier
actual is a part of theclassification
module, but it's directly inside that, unlike the rest of the modules.To fix this, I thought of few ways, such as handling these cases in the code itself. However, the best was I think is simply adding a underscore in front of those files and also fixing the imports after that.
Following files will be fixed:
DummyClassifier
DummyClusterer
SeriesSearch
QuerySearch
RocketGPU
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
No
PR checklist
For all contributions
For developers with write access