-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Distance function notebook #2395 #2487
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
@kevinzb56 there are no new pages describing the new distances in this PR. Did you forget to add and commit them? |
@SebastianSchmidl I’ve added the navigation buttons for the top page and the subpages. Are there any new distances I should include or update? Thanks |
Agreed this does not resolve the issue. The request is to add new notebooks for the different types of distances now available in the module and then a top-level notebook linking summarising and linking to them. The current notebook mainly focuses on elastic distances. As a side note having a ToC is fine, but i wouldnt add "Back to Navigation" in every section. |
Regarding the "Back to Navigation" button, I’ll remove it from the individual sections as per your suggestion. The current module has elastic, mindist, and pointwise distances. Please let me know if I missed anything or if there are further details to address. |
I think its good to have a ToC, but as mentioned this does not fix the issue, so I have edited the automatic issue closer. Still useful though, thanks! |
happy to merge this if you remove the back to navigation |
@TonyBagnall I have removed the 'Back to Navigation' from all sections as requested. Kindly review the changes at your convenience. Thank you! |
Reference Issues/PRs
See #2395
What does this implement/fix? Explain your changes.
The notebook distances.ipyb is very nice, but there is a lot more now in the distances module, and it would be good to easily navigate between top page and sub pages:
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access