Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] FreshPRINCERegressor, RotationForestRegressor and minor changes to FreshPRINCEClassifier #384

Merged
merged 19 commits into from
May 11, 2023

Conversation

dguijo
Copy link
Contributor

@dguijo dguijo commented May 4, 2023

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

  • Modifies the names of FreshPRINCE and RotationForest classifiers to FreshPRINCEClassifier and RotationForestClassifier.
  • Adds the RotationForestRegressor.
  • Adds the FreshPRINCERegressor.
  • Modifies some of the previous tests for time series regression.
  • Adds the smallest multivariate dataset (CardanoSentiment).
  • Modifies the load of the Covid3Month dataset.

Does your contribution introduce a new dependency? If yes, which one?

It doesn't.

What should a reviewer concentrate their feedback on?

  • [] Check that I've modified all old references to FreshPRINCE and RotationForest.
  • [] Check that the tests added for the FreshPRINCEClassifier and FreshPRINCERegressor are correct.
  • [] Check that functions written for loading new TSER datasets are correct.

Did you add any tests for the change?

Yes, for FreshPRINCEClassifier and FreshPRINCERegressor.

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
  • [] For new estimators, I've added the estimator to the online documentation.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@TonyBagnall TonyBagnall added classification Classification package regression Regression package labels May 4, 2023
@dguijo dguijo marked this pull request as ready for review May 4, 2023 22:05
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label May 9, 2023
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contributions David, thanks!

Only a couple of things I think should be changed.

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@MatthewMiddlehurst MatthewMiddlehurst merged commit c504664 into aeon-toolkit:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants