-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] FreshPRINCERegressor, RotationForestRegressor and minor changes to FreshPRINCEClassifier #384
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contributions David, thanks!
Only a couple of things I think should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
It doesn't.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes, for FreshPRINCEClassifier and FreshPRINCERegressor.
PR checklist
For all contributions