-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Tidy up test exclusions #473
Conversation
@hadifawaz1999 I think this is just a random DL fail, I can see no reason for it failing, but could you take a look and see if there is anything |
Hmm thats super weird it shouldn't do that, are you running it locally or just on CI ? will try the test multiple times locally today, will let you know what happens. |
This is from the CI, I think its a form of interference from saving on CI, but I can honestly not see how the network would be uninitialised |
more limited un-exclusion:
|
The CI saving model is now fixed in #485 |
I don't think the latest failure (https://github.com/aeon-toolkit/aeon/actions/runs/5360306587/jobs/9734338503?pr=473) is on our end, so i would disregard it. Seems like its not only us codecov/codecov-action#1003. The PR doesnt actually change the removed estimators list, so not sure why failure #7 happened! I have a hunch some of the DL ones are memory hungry and could be reduced, but thats just speculation |
now I have actually removed the exclusion, this has since ran four times without fail and is I think ready to go in |
Do we have some clue about the other ones still excluded such as HC1 ? @TonyBagnall |
@hadifawaz1999 I'm waiting for @MatthewMiddlehurst 's big revamp of the tree ensembles before going there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR tidies up some of the exclusions in testing/_config.py and updates some of the issues
I have reduced the scope of this to remove just the exclusion for PlateauFinder and HIVECOTEV2, I think maybe incermentally bring others back to give time for intermittent fault finding
Reference Issues/PRs
#472 #347 #271