-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Classifier docs tidy up #52
Conversation
…ssification note books into a directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't go through all changes. More of a general question, if we want to replace sktime with scikit-time.
I guess we do replace as we find it? |
regarding notebooks, we need a proper look at the structure, I'm just triaging here |
I guess, the exclude should be with TEASER, not WEASEL. Even more so, as the failong test is woth TEASER+Catch22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, looks very good to me! Have some minor suggestions/questions, none of them is really a blocker.
tidy up some of the docstrings in base classifier and some other minor things: