added plot visualizing the Italy power data #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
hello @kgmuzungu thanks for the contribution! Matt and I are away at conference this week, so may be a bit slow to look at this, but I think the fail is not from your code |
|
bug independent of this pr for the examples fails, see #747 but its also failing the style test, have you installed pre-commit? Its really helpful for picking these up |
|
@kgmuzungu could you update this from main? The notebook bug has been fixed |
|
I will have a look at it! |
removing some preceding spaces in text
…ngu/aeon_at_kg into adapt_docu_distance_based
|
there were two imports missing in the plotting part. I fixed that. pre-commit had no complains. |
|
looks great, thanks very much for this |
TonyBagnall
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I havnt said hello yet in the Slack channel, but will do. I have been on the PyData Amsterdam. I am really enthusiastic about your project!
Reading through https://www.aeon-toolkit.org/en/latest/examples/classification/distance_based.html I found the Italy power consumption dataset not intuitive. Therefor my suggestion to add a little description plus the plots.
Also and maybe I should not have done this. I allowed all test data and not just the first 10 rows of the test data. The classification is fast enough! Hence I have deleted two rows
X_test = X_test[:10] y_test = y_test[:10]Maybe you like it.
All the best,
Klaus
For all contributions