Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] removed separate mlflow dependencies and testing #81

Merged
merged 5 commits into from
Mar 1, 2023
Merged

[MNT] removed separate mlflow dependencies and testing #81

merged 5 commits into from
Mar 1, 2023

Conversation

aiwalter
Copy link
Contributor

fixes #25

@aiwalter aiwalter added the maintenance Continuous integration, unit testing & package distribution label Feb 19, 2023
@lmmentel
Copy link
Contributor

Are the mlfow related tests going to be run under the general testing call now?

@aiwalter
Copy link
Contributor Author

good question, I cant find where they where excluded before but has to be somewhere? also why is not all CI/CD running, hm

@lmmentel
Copy link
Contributor

lmmentel commented Feb 26, 2023

It seems the tests for mlflow use AutoARIMA and require pmdarima to be installed. There are some unnecessary dependencies in the testing without soft deps and mlfow tests should be excluded from there.

@aiwalter aiwalter requested a review from lmmentel February 28, 2023 11:48
Copy link
Contributor

@lmmentel lmmentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmmentel lmmentel merged commit 1b95096 into aeon-toolkit:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Clean up mlflow dependencies
2 participants