Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add download_dataset function to _data_loaders.py #906

Merged
merged 10 commits into from
Nov 17, 2023
Merged

[ENH] Add download_dataset function to _data_loaders.py #906

merged 10 commits into from
Nov 17, 2023

Conversation

PaulRabich
Copy link
Contributor

Added a function download_dunction to the _data_loaders.py file.
This functions only downloads a dataset without loading it to memory.

and update numpy dependency in pyproject.toml
@aeon-actions-bot aeon-actions-bot bot added the datasets Datasets and data loaders label Nov 16, 2023
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon!

I did not find any labels to add based on the title. Please add the ENH, MNT, BUG, DOC and/or GOV tag to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#0B1D38}{\textsf{datasets}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any!

@MatthewMiddlehurst MatthewMiddlehurst changed the title Add download_dataset function to _data_loaders.py [ENH] Add download_dataset function to _data_loaders.py Nov 16, 2023
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Nov 16, 2023
TonyBagnall
TonyBagnall previously approved these changes Nov 16, 2023
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo and a formatting request but thanks for this. I think the testing for this needs a bit of a rework, so will add a test for next coverage push.

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If testing will be done in a different PR, I think my only issue is the docs name as well. Fine with it going in after.

@MatthewMiddlehurst
Copy link
Member

Ignore the failure, unrelated and dealt with in a different PR.

@PaulRabich
Copy link
Contributor Author

Anything else to do?

@TonyBagnall TonyBagnall merged commit 8fe9c29 into aeon-toolkit:main Nov 17, 2023
@TonyBagnall
Copy link
Contributor

thanks for this

@MatthewMiddlehurst
Copy link
Member

@all-contributors add @PaulRabich for code

Copy link
Contributor

@MatthewMiddlehurst

I've put up a pull request to add @PaulRabich! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants