-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add download_dataset function to _data_loaders.py #906
Conversation
and update numpy dependency in pyproject.toml
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny typo and a formatting request but thanks for this. I think the testing for this needs a bit of a rework, so will add a test for next coverage push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If testing will be done in a different PR, I think my only issue is the docs name as well. Fine with it going in after.
Ignore the failure, unrelated and dealt with in a different PR. |
Anything else to do? |
thanks for this |
@all-contributors add @PaulRabich for code |
I've put up a pull request to add @PaulRabich! 🎉 |
Added a function
download_dunction
to the_data_loaders.py
file.This functions only downloads a dataset without loading it to memory.