Better error when sending a tx with a too large extra field /monero#5182 #102
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneromooo-monero
approved these changes
Feb 22, 2019
|
This change is specific to Aeon fixing an issue made in #39. |
Note: the 'tx weight' idiom was adapted to the older 'tx size' idiom since PR monero-project#4219 which introduced the former hasn't been merged yet
stoffu
force-pushed
the
aeon-big-ring
branch
from
a017785 to
e2be8bf
Compare
stoffu
changed the title
|
I've replaced the patch with @moneromooo-monero's version monero-project#5182. Note that the 'tx weight' idiom was adapted to the older 'tx size' idiom since PR monero-project#4219 which introduced the former hasn't been merged yet. |
|
Fixes #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where a tx with even a single output cannot be created due to size limit