Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define common components for oneof parity across protobuf and OAS. #16
base: main
Are you sure you want to change the base?
Define common components for oneof parity across protobuf and OAS. #16
Changes from all commits
d127a56
349c0ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the examples in aep.dev or json - shouldn't this also be json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In proto, oneof is not a nested object. Will this schema be wire compatible with proto?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. I'm not aware of a way to solve that, unfortunately. Wire compatibility would be great but I'm not sure it's feasible, and I'm also not sure banning oneofs (and other things) in the AEPs is worth the benefit of wire compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is a tricky one. We'd end up having to write our own generator to map the concepts appropriately.
I don't think those who write native HTTP / JSON APIs will like the idea of nested fields as a way of defining oneofs - I sure don't. But it is possible to use the oneof annotation in such a way that proto -> json mappings will still be compliant (just with an additional nested layer).
I think it's best to have OpenAPI / HTTP+JSON have freedom to define it's own interface for now from the resource model (aepc) - then see the discrepancies and make a decision on how much compatibility we want from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will OAS introduce native support for oneof?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in OAS 4, but not sure. Good question for @hudlow or @earth2marsh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a list, so there can be multiple oneofs. something like:
also do we need a name for this oneof?