Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop loop kwarg from async_timeout.timeout #61

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Drop loop kwarg from async_timeout.timeout #61

merged 2 commits into from
Jan 12, 2022

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Nov 4, 2021

  • async_timeout 4.0.0 drops the loop= kwarg and will fail if its passed

@bdraco
Drop loop kwarg from async_timeout.timeout
777e19b 
- async_timeout 4.0.0 drops the loop= kwarg and will fail if its passed
@bdraco bdraco mentioned this pull request Nov 4, 2021
Merged
22 tasks
@aequitas
Copy link
Owner

aequitas commented Nov 4, 2021

Is there a way to keep this backwards compatible while still supporting async_timeout>4?

@bdraco
Copy link
Contributor Author

bdraco commented Nov 4, 2021

The loop argument is optional in 3.0.1 and will use the running event loop if it is not passed

https://github.com/aio-libs/async-timeout/blob/v3.0.1/async_timeout/__init__.py#L31

@frenck frenck mentioned this pull request Jan 10, 2022
Closed
22 tasks
@aequitas aequitas merged commit ddf4b91 into aequitas:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @aequitas