Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal operations #365

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

internal operations #365

wants to merge 25 commits into from

Conversation

kroggen
Copy link
Member

@kroggen kroggen commented Oct 3, 2024

This feature:

  • Records the internal operations in the node database
  • Encode them as JSON string, all transactions from a block (store just once per block to reduce I/O, using the block number as key)
  • Adds a RPC endpoint to retrieve these values

Currently it will log:

  • calls to other contracts (contract.call)
  • delegate call (contract.delegatecall)
  • deploy of other contracts (contract.deploy)
  • send / transfer of aergo tokens (contract.send)
  • stake
  • unstake
  • vote
  • voteDAO

The deploy and send can also trigger a call to the contract (call to the constructor and to the default function). These internal calls are also recorded

Maybe in the future (HF 5) it can also log:

  • state variables (set and delete)
  • db exec

@hayarobi
Copy link
Member

All tests need to be passed.

@kroggen
Copy link
Member Author

kroggen commented Oct 14, 2024

It is passing now.
There are no tests specific to this feature, though.

Note that this is not intended to be merged now. It lacks a sync test, and manual tests with the indexer.
It can be merged into develop later

@kroggen kroggen changed the base branch from topic/hardfork-v4 to develop October 29, 2024 04:40
Copy link
Member

@hayarobi hayarobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants