Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using more standard web.xml #16

Merged

Conversation

BertScholten
Copy link
Member

@BertScholten BertScholten commented Mar 8, 2024

Based on https://github.com/geoserver/geoserver/blob/main/src/web/app/src/main/webapp/WEB-INF/web.xml Changes wrt that version:

  • license header
  • cors enabled
  • jdbc resource ref

Formatted with 4 spaces indentation, which is most similar to what geoserver uses.

Actual changes: session-config surrounding cookies, and yaml as a mime-type.

Based on https://github.com/geoserver/geoserver/blob/main/src/web/app/src/main/webapp/WEB-INF/web.xml
Changes wrt that version:
* license header
* cors enabled
* jdbc resource ref
Copy link
Member

@SerhatG SerhatG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd probably enable the secure flag as well on the cookies, but not sure if developers use the UI locally or just copy/paste layers and test it using CICD.

@BertScholten BertScholten merged commit 5f66dee into aerius:main Mar 8, 2024
1 check passed
@BertScholten BertScholten deleted the use_geoserver_web_xml_as_template branch March 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants