Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AER-1322 - Fix regex errors #30

Merged
merged 3 commits into from
Jan 30, 2023
Merged

AER-1322 - Fix regex errors #30

merged 3 commits into from
Jan 30, 2023

Conversation

JornC
Copy link
Member

@JornC JornC commented Jan 30, 2023

  • Escape the regex origin text so it is not itself interpreted as regex (this fixes an error produced when characters like \ or ? are entered)
  • Remove backslashes from the ultimate query (this fixes an error produced when \ is interpreted as a regex)

@JornC JornC changed the title Fix regex errors AER-1322 - Fix regex errors Jan 30, 2023
BertScholten
BertScholten approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@BertScholten BertScholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JornC JornC merged commit b144bad into aerius:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BertScholten BertScholten BertScholten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JornC @BertScholten