Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AER-2293 Set automatic recovery to false for RabbitMQ library #66

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

SerhatG
Copy link
Member

@SerhatG SerhatG commented Nov 21, 2023

As of 4.0.0 of the library this is true by default which will not mix well with our own connection retries. In a future version we might want to use this rather than have our own implementation. See https://www.rabbitmq.com/api-guide.html#recovery for more information.

As of 4.0.0 of the library this is true by default which will not mix well with our own connection retries.
In a future version we might want to use this rather than have our own implementation.
See https://www.rabbitmq.com/api-guide.html#recovery for more information.
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SerhatG SerhatG merged commit a26d3db into aerius:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants