Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Add categories to templates - community, external etc. #2086

Open
wtrocki opened this issue Sep 19, 2020 · 10 comments
Open

Add categories to templates - community, external etc. #2086

wtrocki opened this issue Sep 19, 2020 · 10 comments
Labels
enhancement New feature or request templates

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Sep 19, 2020

Is your feature request related to a problem? Please describe.
Please describe the problem you are trying to solve.

Describe the solution you'd like
Please describe the desired behavior.

Describe alternatives you've considered
Please describe alternative solutions or features you have considered.

@wtrocki wtrocki added the enhancement New feature or request label Sep 19, 2020
@machi1990
Copy link
Contributor

/cc @craicoverflow, @machi1990
Automatically generated comment to notify maintainers

@wtrocki
Copy link
Contributor Author

wtrocki commented Sep 21, 2020

More context here. We will be working with partners to try out their work and we need a way to include their templates into graphback for recognition and also association with technologies we cannot or have time to investigate.

@craicoverflow
Copy link

Would the templates live in the repo, or will they be pulled from multiple sources, so that they do not all need to live inside the repo?

@wtrocki
Copy link
Contributor Author

wtrocki commented Sep 21, 2020

Never in the repo. Entire concept will be to have them as community ones that might get outdated etc. after a while. This is one of the strategies that we will cover to promote graphback - it actually requires technical investment because I would not expect creator to add this capability (separate sort for community ones) - just add link to repo and that will be it.

@machi1990
Copy link
Contributor

Never in the repo. Entire concept will be to have them as community ones that might get outdated etc. after a while. This is one of the strategies that we will cover to promote graphback - it actually requires technical investment because I would not expect creator to add this capability (separate sort for community ones) - just add link to repo and that will be it.

We already have the ability to indicate template's url

args.option('templateUrl', {

If I understood correctly, the use case here is to be able to indicate that an template is a community provided or an external template if the url does not match graphback's templates repository?

@craicoverflow
Copy link

craicoverflow commented Sep 21, 2020

IIRC that flag does not work.

#1043 not sure why we closed this

@wtrocki
Copy link
Contributor Author

wtrocki commented Sep 21, 2020

Ah.. idea here is to actually embedd them into some separate json file that people can edit and list them on init (but with header - those are community maintained).
So people can get something they feel familiar with.

@machi1990
Copy link
Contributor

Ah.. idea here is to actually embedd them into some separate json file that people can edit and list them on init (but with header - those are community maintained).
So people can get something they feel familiar with.

Even better.

@RinkiyaKeDad
Copy link
Contributor

Hi! Can I work on this? As far as I understand the goal is that people should be able to provide a link to their template (a JSON file) by using something like: graphback init --templateUrl=<link-goes-here>? What would be a good starting point for solving this? Thanks.

@wtrocki
Copy link
Contributor Author

wtrocki commented Nov 11, 2020

I was thinking we can actually create templates.json file in repo where community can add their templates.
Graphback-cli project have them hard coded for the moment so we can split between community and base templatez

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request templates
Projects
None yet
Development

No branches or pull requests

4 participants