Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Community templates #2232

Closed
wants to merge 5 commits into from
Closed

Community templates #2232

wants to merge 5 commits into from

Conversation

RinkiyaKeDad
Copy link
Contributor

Fix for #2086

Types of changes

What types of changes does your code introduce to Graphback?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Other (please specify)

Checklist

  • I have read the CONTRIBUTING document.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

I've added the changes from both mine and @wtrocki's PR to this one. The current status is:

  1. There is a community-templates.ts file present in the packages directory.
  2. This file contains an externalTemplates array where people can add their template as an object.
  3. The externalTemplates array gets imported into the starterTemplates.ts file where templates from it get added to the allTemplates array.
  4. Made changes to the way few things were imported in different files as they were giving errors in previous PR. (this might not be needed now)
  5. Added a draft of the documention which will be changed based on suggestions.

Please let me know if you have any suggestions and what further steps I should take. Much thanks.

Copy link
Contributor

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job. I will look into why build is failing

@@ -0,0 +1,59 @@
# Using Graphback With Your Own Templates

In case you want to use some other templates than the ones offered, Graphback also supports adding your templates. The process is fairly simple and is as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In case you want to use some other templates than the ones offered, Graphback also supports adding your templates. The process is fairly simple and is as follows:
Graphback has ability to include community templates. To add community template please:

@wtrocki
Copy link
Contributor

wtrocki commented Dec 16, 2020

I need to rebase and squash this work in order to get this working

@wtrocki wtrocki closed this Dec 16, 2020
@RinkiyaKeDad RinkiyaKeDad deleted the community-templates branch December 18, 2020 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants