-
Notifications
You must be signed in to change notification settings - Fork 73
fix(graphql-migrations): migration failed for auto increments column #2071
fix(graphql-migrations): migration failed for auto increments column #2071
Conversation
cb5763a
to
1683a64
Compare
I've added one comment. I'll properly test this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added one comment. I'll properly test this tomorrow.
I am still seeing the error
alter table "public"."note" alter column "_id" drop not null - column "_id" is in a primary key
I used the postgres templates.
I guess it might be the fact that the the column in database has a default value while the parsed column from the schema does not. This does not go well with the diff computation.
Weird, you have run |
1683a64
to
f82f88c
Compare
Yes. |
748f0c1
to
83a80cd
Compare
Migrations failed if the field was not "id" and the scalar was "ID"
I was testing the first patch and forgot to rebase over the latest change you've made today. This seems to be no longer the issue and the PR fixes the problem. Thanks for driving this baby home :-) |
Fixes #2047
Could not add a unit test for this because it is only a Postgres issue - we do need to think about integration tests for this scenario but due to it being a blocker we should get it merged and release first.