feat: add ability to perform package override in config #2077
Conversation
|
Pushed some changes to fix this, will add documentation now also. |
|
I'm looking if that is something you would accept. I see couple issues:
I have made change in node_modules and ported it to repo (but improperly). |
Yes, although I changed the property name from I will look to add docs change in another PR and we can get this merged and released. |
|
@craicoverflow - I found way out. If I define output file in runtime (schema plugin) I will get schema updated so this is not priority but when we land this I would be able to do proper setup in datasync starter. Thank you so much! |
| let pluginName = pluginLabel; | ||
| if (pluginLabel.startsWith('graphback-')) { | ||
| // Internal graphback plugins needs rename | ||
| pluginName = pluginLabel.replace('graphback-', '@graphback/codegen-'); | ||
| } | ||
| // override package name | ||
| if(pluginConfigMap[pluginLabel].packageNameOverride){ | ||
| pluginName = pluginConfigMap[pluginLabel].packageNameOverride; |
There was a problem hiding this comment.
| pluginName = pluginConfigMap[pluginLabel].packageNameOverride; | |
| pluginName = pluginConfigMap[pluginLabel].packageName |
craicoverflow
force-pushed
the
package-override
branch
from
4c6e563 to
0c2dcd6
Compare
I can approve but should not approve myself, @machi1990 mind taking a look? |
craicoverflow
force-pushed
the
package-override
branch
from
0c2dcd6 to
04fad31
Compare
craicoverflow
changed the title
I have noticed that https://github.com/aerogear/graphback/blob/package-override/docs/plugins/creating-your-own-plugin.md no longer has information about config as well.