This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
remove empty resolver creation in plugin #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craicoverflow
force-pushed
the
add-schema-must-haves
branch
from
5f8b616 to
872eb12
Compare
craicoverflow
changed the title
craicoverflow
commented
Sep 24, 2020
| @@ -1,5 +1,5 @@ | |||
| import yargs from 'yargs'; | |||
| import * as chalk from 'chalk'; | |||
There was a problem hiding this comment.
@machi1990 I know that you changed this back, but I was getting a build error:
Unsafe call of an any typed value. Any reason the import alias is preferred here?
There was a problem hiding this comment.
This was changed in #2026 since the printSchema command was not working.
There was a problem hiding this comment.
I've accepted the change without re-verifying this part as it seems unrelated. I trust you on that and the command should work.
There was a problem hiding this comment.
Okay it is not working for me now - what I will do is disable that line with eslint
machi1990
approved these changes
Sep 24, 2020
craicoverflow
force-pushed
the
add-schema-must-haves
branch
from
872eb12 to
faf172d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2117
The DataSyncPlugin was creating empty root Query, Mutation and Subscription resolver objects.