Refactor #2
Refactor #2
Conversation
|
Please add license and copyright to every single .php file: /**
* Aero.io API client for PHP
*
* @copyright Copyright 2012, aero.io (http://aero.io)
* @license The MIT License
*/ |
|
Please setup Travis CI to run the tests on each commit in master, and add a travis badge to the "Readme" file. Make sure it will run them on PHP versions: 5.2, 5.3 and 5.4 (if available) |
| * Engine interface. | ||
| * | ||
| * Interface that should be used by all of the supplied engines. | ||
| */ | ||
| interface Engine { | ||
| public function execute($request); |
| * | ||
| * @var array | ||
| */ | ||
| protected $schema = array( |
There was a problem hiding this comment.
This schema is a bit incomplete, please include not only the main attributes, but all of them, except checksum and announced.
|
You've used tabs instead of 4 spaces in a lot of files, for example |
|
|
|
You have no tests for the |
Final changes and additions.