-
Notifications
You must be signed in to change notification settings - Fork 133
Initial Chromium image support for arm64 #524
Initial Chromium image support for arm64 #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=========================================
- Coverage 6.24% 5.87% -0.37%
=========================================
Files 7 8 +1
Lines 785 834 +49
=========================================
Hits 49 49
- Misses 729 778 +49
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay.
- Need to delete
devtools
source code completely if there are no changes compared to Chrome. Instead copy source code to temporary context directory with Go code inchromium.go
. - Need to use Ubuntu 20.04 base image if possible. Ubuntu 18.04 end of support is in 2023.
All the rest seems to be OK.
…d to run Selenoid on M1. See `build-chromium.sh` for details or just pull `sskorol/selenoid_chromium_vnc:100.0` for testing. Note that your `browsers.json` should label this image as chrome. Your Selenium tests should also pass a `browserName = chrome` capability as `chromium` isn't explicitly supported for filtering. Base image should be built with UBUNTU_VERSION=18.04 arg for M1 as Focal doesn't have fresh updates for Chromium. Also note that `libgtk-3-0` package is required for Chromium image. Otherwise, a browser just crashes in runtime with 500 error from Selenoid. DevTools support was temporary removed due to an issue accessing Chrome sub-folder from Chromium docker context for further reusing during the build.
ef468d4
to
fd7df2e
Compare
@vania-pooh as discussed in a chat, devtools were temporary removed from PR. The other issue regarding the version was fixed. So feel free to review. |
@sskorol thank you for contribution! |
@vania-pooh Is there any plan to publish the Aerokube's browser images supporting ARM (e.g. for Chrome) in Docker Hub? Thanks! |
@bonigarcia probably. :) |
@vania-pooh any chance you guys can publish arm images? It would be super helpful, we only keep x86 nodes for moon and selenoid tests. Thanks in advance! |
@pavelbrylov usually people need to test under Google Chrome and this is not possible with ARM64, only Chromium. |
Hello @sskorol! Could you please provide us a guideline/documentation on how we can create our own images? Thank you in advance! I have tried running the Just to add that I am getting the following error:
|
Hello @sskorol! Thank you for your work. Tried to build an image using |
@vania-pooh still no plans to build arm images? |
@nickmsix I was able to create a latest image for chromium. You can check here |
@gromanas wow, your image works perfectly, greate job!!! 👍👍👍 |
@nickmsix Glad that I helped. Will try. I need to find where such info can be hosted. Maybe a readme here or a post on a tech site. I will keep you posted. |
@gromanas Thank you very much! Appreciate it a lot. |
Initial implementation of a Chromium image for arm64 which is required to run Selenoid on M1. See build-chromium.sh (TBR) for details or just pull sskorol/selenoid_chromium_vnc:100.0 for testing.
Note that your
browsers.json
should label this image as chrome:Your Selenium tests should pass a
browserName = chrome
capability aschromium
isn't explicitly supported for filtering.The base image was downgraded to ubuntu:18.04 as Focal doesn't have fresh updates for Chromium. Also, note that
libgtk-3-0
package is required for the Chromium image. Otherwise, a browser just crashes in runtime with a 500 error from Selenoid.Fixes #449
@vania-pooh feel free to review and revise if required. I haven't tested all the potential scenarios (with /local build and dev tools).