Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang generation broken for MetaAttribute #620

Closed
ethanf opened this issue Dec 5, 2018 · 0 comments
Closed

Golang generation broken for MetaAttribute #620

ethanf opened this issue Dec 5, 2018 · 0 comments

Comments

@ethanf
Copy link
Contributor

ethanf commented Dec 5, 2018 

$ cd gocode/ && make
./Simple0.go:378:17: (*Simple0).Simple0MetaAttribute redeclared in this block
	previous declaration at ./Simple0.go:336:6

Broken in 435f88e, which is the 1.8.9 release.

There should probably be a travis build for golang.
ethanf added a commit to ethanf/simple-binary-encoding that referenced this issue Dec 5, 2018
@ethanf
[golang] Fix code gen for MetaAttributes. Issue aeron-io#620.
16d875d
mjpt777 added a commit that referenced this issue Dec 6, 2018
@mjpt777
Merge pull request #621 from ethanf/ethanf/issue-620
8e91221 
[golang] Fix code gen for MetaAttributes. Issue #620.
@mjpt777 mjpt777 closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjpt777 @ethanf