[C++]: Composite type generation

[ksergey]

C++ generator produce*Id() fields for composite type elements. Is there any reason for that?
Elements from composite type don't have property id and generated methods always return 0.

[ksergey]

I think code below should be if-ed

    private void generateFieldCommonMethods(                                                                                                                   
        final String indent,                                                                                                                                   
        final StringBuilder sb,                                                                                                                                
        final Token fieldToken,                                                                                                                                
        final Token encodingToken,                                                                                                                             
        final String propertyName)                                                                                                                             
    {                                                                                                                                                          
        sb.append(String.format("\n" +                                                                                                                         
            indent + "    static SBE_CONSTEXPR std::uint16_t %1$sId() SBE_NOEXCEPT\n" +                                                                        
            indent + "    {\n" +                                                                                                                               
            indent + "        return %2$d;\n" +                                                                                                                
            indent + "    }\n",                                                                                                                                
            propertyName,                                                                                                                                      
            fieldToken.id()));     

[tmontgomery]

Things could be re-arranged so that the method is not generated by treating the composite differently than the normal messages. And probably could make a few other optimizations while at it.

[mjpt777]

Correct @tmontgomery.