New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect header included for quiet_NaN #956

Closed

Bu11etmagnet opened this issue Sep 27, 2023 · 0 comments

Bu11etmagnet commented Sep 27, 2023

https://github.com/real-logic/simple-binary-encoding/blob/master/sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java#L1055 says that "cmath needed for quiet_NaN". This is incorrect. std::numeric_limits is defined in <limits>, not <cmath>. This happens to work as long as cmath happens to include limits, but will break if Standard C+ Library headers are reorganized.

The text was updated successfully, but these errors were encountered:

mjpt777 added a commit that referenced this issue


          [C++] Rely on NAN from limits rather than pulling in cmath. Issue #956.

0a05d9a

mjpt777 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment