Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Methods to calculate the length of an SBE message #761

Merged
merged 9 commits into from
Mar 18, 2020

Conversation

agmt
Copy link
Contributor

@agmt agmt commented Mar 4, 2020

Implements: #291

@agmt agmt force-pushed the master branch 2 times, most recently from e04fe8c to 693c052 Compare March 4, 2020 13:37
@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2020

This pull request introduces 1 alert when merging 693c052 into 6ec0439 - view on LGTM.com

new alerts:

  • 1 for Boxed variable is never null

@mjpt777
Copy link
Contributor

mjpt777 commented Mar 4, 2020

Will look in more detail in at a later date. Got a bit too much on at the minute.

One thing on naming. Something that will calculate the total so be named to reflect that it is not a simple accessor. Something like computeEncodedLength.

@agmt
Copy link
Contributor Author

agmt commented Mar 5, 2020

@mjpt777 noticed. New function names are: static computeLength(...) (to predict message length before encoding) and decodeLength() const (to find length in the beginning of decoding).

@mjpt777
Copy link
Contributor

mjpt777 commented Mar 9, 2020

I see you were fixing some warnings in addition to this. I've picked those up independently.

@agmt
Copy link
Contributor Author

agmt commented Mar 10, 2020

I've rebased on master

@mjpt777
Copy link
Contributor

mjpt777 commented Mar 17, 2020

Be good to get @tmontgomery view on this.

@tmontgomery tmontgomery merged commit a21fe87 into aeron-io:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants