-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: vec-290 change basic, quote, and prism example default AVS dat… #53
Conversation
…a and index namespaces to avs-data and avs-index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes are needed to any docker compose or config files? I am wondering if quote/prism worked prior to these changes if they still relied on the test namespace?
They work if your deployment uses the test namespace. The docker compose files set the environment variables so that these examples use the ave-data and avs-index separate namespaces, so they work either way. That's what Adam wanted when I spoke with him originally, "test" by default and separate namespaces with the docker composes. |
Co-authored-by: Jesse S <jschmidt@aerospike.com>
…ocker compose for quote and image search
@jdogmcsteezy I removed the environment variables for separate namespaces from the example dockerfiles as they are now defaults in the apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming it is tested, LGTM
These are tested locally. I'll merge this after the conflicts are fixed. |
…a and index namespaces to avs-data and avs-index. Also adds a readme note about the use of separate namespaces for AVS to each example.