VEC-317 0.9.1 support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdogmcsteezy
commented
Aug 29, 2024
jdogmcsteezy
commented
- change --hnsw-max-records to --hnsw-m
- change --hnsw-healer-schedule-delay to --hnsw-healer-schedule
- change --hnsw-merge-parallelism to --hnsw-merge-index-parallelism
- add --hnsw-merge-reindex-parallelism
added 2 commits
August 29, 2024 13:06
- change --hnsw-max-records to --hnsw-m - change --hnsw-healer-schedule-delay to --hnsw-healer-schedule - change --hnsw-merge-parallelism to --hnsw-merge-index-parallelism - add --hnsw-merge-reindex-parallelism
|
Can be reviewed now. Small changes to the docker compose files will be needed once AVS 0.9.1 is released and changes to the go-client are merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 83.80% 83.81% +0.01%
==========================================
Files 41 41
Lines 2772 2775 +3
==========================================
+ Hits 2323 2326 +3
Misses 348 348
Partials 101 101 ☔ View full report in Codecov by Sentry. |
dwelch-spike
approved these changes
Aug 30, 2024
dwelch-spike
reviewed
Sep 9, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.