Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vec-327 vec-372 deprecate field_names, add include_fields and exclude_fields optional arguments to client.get a… #51

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

dwelch-spike
Copy link
Contributor

…nd client.vector_search() to filer out fields returned by the AVS server

…nd client.vector_search() to filer out fields returned by the AVS server
@dwelch-spike dwelch-spike self-assigned this Sep 21, 2024
@dwelch-spike dwelch-spike changed the base branch from main to dev September 21, 2024 00:03
@dwelch-spike dwelch-spike marked this pull request as draft September 21, 2024 00:04
@dwelch-spike dwelch-spike marked this pull request as ready for review September 21, 2024 00:05
…ent. Add include_fields and exclude_fields arguments to those functions. fix: issue where an empty list used as field_names argument would still include all result fields.
Copy link
Collaborator

@DomPeliniAerospike DomPeliniAerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments and questions, but overall it looks great! Let me know when you address the comments, and I will come back around to approve.

src/aerospike_vector_search/aio/client.py Show resolved Hide resolved
src/aerospike_vector_search/aio/client.py Show resolved Hide resolved
src/aerospike_vector_search/aio/client.py Show resolved Hide resolved
src/aerospike_vector_search/client.py Show resolved Hide resolved
src/aerospike_vector_search/client.py Show resolved Hide resolved
tests/standard/sync/test_vector_search.py Outdated Show resolved Hide resolved
tests/standard/sync/test_vector_search.py Outdated Show resolved Hide resolved
src/aerospike_vector_search/types.py Show resolved Hide resolved
src/aerospike_vector_search/types.py Show resolved Hide resolved
src/aerospike_vector_search/types.py Show resolved Hide resolved
Copy link
Collaborator

@DomPeliniAerospike DomPeliniAerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments have been sufficiently addressed and new changes look good. Approving now! Great work!

@dwelch-spike dwelch-spike changed the title feat: vec-327 add field_exclusions optional parameter to client.get a… feat: vec-327 vec-372 deprecate field_names, add include_fields and exclude_fields optional arguments to client.get a… Sep 27, 2024
@dwelch-spike dwelch-spike merged commit 2c6a44a into dev Sep 27, 2024
18 of 20 checks passed
@dwelch-spike dwelch-spike deleted the vec-327 branch September 27, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants