-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vec-327 vec-372 deprecate field_names, add include_fields and exclude_fields optional arguments to client.get a… #51
Conversation
…nd client.vector_search() to filer out fields returned by the AVS server
…ent. Add include_fields and exclude_fields arguments to those functions. fix: issue where an empty list used as field_names argument would still include all result fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments and questions, but overall it looks great! Let me know when you address the comments, and I will come back around to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments have been sufficiently addressed and new changes look good. Approving now! Great work!
…nd client.vector_search() to filer out fields returned by the AVS server