Initial Commit #6

DomPeliniAerospike · 2024-04-04T17:21:15Z

No description provided.

Cleaned up typing Changed parameters to have PEP compliant conventions Listed parameters one per line (aside from self, *,) Added types from types_pb2 as python objects

initialized test suite made function names PEP compliant Added keyword arguments some functions

Async support added to project (sync support removed) Added basic unit testing Removed proto notes in types.py

Organized imports

Changed private functions from two underscores to one.

Added wait for completion on delete Added smoke tests for all API's Ran black and flake8 Added Logging

Added setup files in test dir

…aerospike-proximus-client-python into black-format

Update

…e-proximus-client-python into main

Black format

Added fixes for github actions testing

hev

I glanced over this but I think it's too in the weeds and big of PR for me to really weigh in. Approved.

jdogmcsteezy · 2024-04-04T23:45:34Z

.flake8

@@ -0,0 +1,2 @@
+[flake8]
+ignore = E501


Suggested change

ignore = E501

max-line-length = 88 # black compatability

ignore = E501, E203 # black compatability

I believe all three are needed for black compatibility

jdogmcsteezy · 2024-04-04T23:47:06Z

.github/workflows/unit_test.yml

The file is called unit_tests.yml, but it looks more like integration/e2e because you are spinning up aerospike/proximus

jdogmcsteezy · 2024-04-04T23:55:10Z

src/aerospike_vector/index_pb2_grpc.py

Isn't this code auto-generated? If that's the case we might want to tell black to ignore the autogenerated files? Otherwise, we will need to ensure that black gets run on each newly generated file

jdogmcsteezy · 2024-04-05T17:04:50Z

src/aerospike_vector/types.py



 class HostPort(object):
-    def __init__(self, address: str, port: int, isTls=False):
-        self.address = address
+    def __init__(self, *, host: str, port: int, isTls: Optional[bool] = False) -> None:


Why only keyword arguments?

jdogmcsteezy · 2024-04-05T17:06:58Z

src/aerospike_vector/types.py

+    def __str__(self):
+        bins_info = ""
+        for key, value in self.bins.items():
+            if isinstance(value, list):


Should we also handle dicts?

jdogmcsteezy · 2024-04-05T17:52:31Z

src/aerospike_vector/vectordb_channel_provider.py


+                except Exception as e:


jdogmcsteezy · 2024-04-05T17:54:25Z

src/aerospike_vector/vectordb_channel_provider.py

+                    endpoint.address, endpoint.port, endpoint.isTls
+                )
+            except Exception as e:
+                warnings.warn("error creating channel: " + str(e))


jdogmcsteezy · 2024-04-05T17:55:53Z

src/aerospike_vector/vectordb_channel_provider.py

-                                             endpoints: vector_db_pb2.ServerEndpointList) -> grpc.Channel:
+    def _create_channel_from_server_endpoint_list(
+        self, endpoints: vector_db_pb2.ServerEndpointList
+    ) -> grpc.aio.Channel:
        # TODO: Create channel with all endpoints


Is the TODO completed by looping through all endpoints?

jdogmcsteezy · 2024-04-05T17:57:52Z

src/aerospike_vector/vectordb_channel_provider.py

-        host = re.sub(r'%.*', '', host)
-        return grpc.insecure_channel(f'{host}:{port}')
+        host = re.sub(r"%.*", "", host)
+        return grpc.aio.insecure_channel(f"{host}:{port}")


Again, I am surprised that this does not need an await. Can you help me understand that if you know why?

jdogmcsteezy · 2024-04-05T18:00:05Z

src/aerospike_vector/vectordb_client.py

-        bin_selector = self.__getBinSelector(bin_names)
+            self.__channelProvider.get_channel()
+        )
+        key = _get_key(key, set_name, namespace)


I find the order of these args to be unsettling :)

DomPeliniAerospike added 13 commits March 26, 2024 08:39

VEC-109

e9cce8c

Cleaned up typing Changed parameters to have PEP compliant conventions Listed parameters one per line (aside from self, *,) Added types from types_pb2 as python objects

VEC-109

72db18b

initialized test suite made function names PEP compliant Added keyword arguments some functions

VEC-94

331b021

Async support added to project (sync support removed) Added basic unit testing Removed proto notes in types.py

Ran black-formatter

0bdb605

Fixed Flake 8 errors

7f081b0

Organized imports

Added pydoc boilerplate

3956640

Changed private functions from two underscores to one.

Added Vector search testing

86c836c

Added wait for completion on delete Added smoke tests for all API's Ran black and flake8 Added Logging

Merge branch 'dev' into black-format

6f252a8

Added unit test action

5ed4463

Added setup files in test dir

Merge branch 'black-format' of https://github.com/DomPeliniAerospike/…

bf6bf2e

…aerospike-proximus-client-python into black-format

Update pyproject.toml

a3d763d

Update unit_test.yml

5c52b08

Merge branch 'dev' into black-format

9cdaa52

DomPeliniAerospike requested review from ashishshinde, justinlee-aerospike, hev and jdogmcsteezy April 4, 2024 18:27

DomPeliniAerospike added 13 commits April 4, 2024 11:54

Merge pull request #2 from DomPeliniAerospike/update

a469aa5

Update

Added testing

edcb997

Merge branch 'main' of https://github.com/DomPeliniAerospike/aerospik…

7f13793

…e-proximus-client-python into main

Update unit_test.yml

af08458

Update unit_test.yml

745b365

Update unit_test.yml

e4040af

Update unit_test.yml

60ba9a5

Update unit_test.yml

fcb4ae0

Update unit_test.yml

7ecfb36

Update unit_test.yml

c913622

Update unit_test.yml

50b30e0

Update requirements.txt

952bf4c

Merge branch 'main' into black-format

614c047

DomPeliniAerospike added 4 commits April 4, 2024 12:30

Merge pull request #1 from DomPeliniAerospike/black-format

3713e54

Black format

Update vectordb_channel_provider.py

326a8e9

Removed print statements and corrected expected result

efb9823

Merge pull request #3 from DomPeliniAerospike/main

cfcc943

Added fixes for github actions testing

hev approved these changes Apr 5, 2024

View reviewed changes

jdogmcsteezy reviewed Apr 5, 2024

View reviewed changes

DomPeliniAerospike closed this by deleting the head repository Apr 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Commit #6

Initial Commit #6

DomPeliniAerospike commented Apr 4, 2024

hev left a comment

jdogmcsteezy Apr 4, 2024

jdogmcsteezy Apr 4, 2024

jdogmcsteezy Apr 4, 2024

jdogmcsteezy Apr 5, 2024

jdogmcsteezy Apr 5, 2024

jdogmcsteezy Apr 5, 2024

jdogmcsteezy Apr 5, 2024

jdogmcsteezy Apr 5, 2024

jdogmcsteezy Apr 5, 2024

jdogmcsteezy Apr 5, 2024

	ignore = E501
	max-line-length = 88 # black compatability
	ignore = E501, E203 # black compatability

Initial Commit #6

Initial Commit #6

Conversation

DomPeliniAerospike commented Apr 4, 2024

hev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment