chore: rebuild with and require protobuf 5.28.3 to silence grpc minor… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version difference warnings vec-420
rahul-aerospike
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 71.52% 71.52%
=======================================
Files 25 25
Lines 2286 2286
=======================================
Hits 1635 1635
Misses 651 651 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… version difference warnings vec-420
@rahul-aerospike Looks like those warnings we are seeing were rolled back in the next version of protobuf protocolbuffers/protobuf#18096 . Upgrading the required protobuf version removes the warnings for me. It seems like grpcio-tools current protoc version is set to 5.27 for now so I don't think we can build with a newer protoc until they upgrade that.
Once we cut another release with these changes the warnings should disappear.