-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Gibbs sampler for the regularized logistic regression #13
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 99 128 +29
Branches 6 10 +4
=========================================
+ Hits 99 128 +29
Continue to review full report at Codecov.
|
d38fe00
to
880783f
Compare
880783f
to
6a70509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this refactoring. Just don't be surprised if it's refactored again soon, because this project is likely to undergo large changes quickly.
Is this ready for review or should I wait till its no longer in draft state? @rlouf |
6a70509
to
0cb5040
Compare
b686e1e
to
5e8171d
Compare
@zoj613 All checks pass now. Waiting for your review to merge. |
This PR adds a Gibbs sampler for the regularized binary logistic regression, as presented in Makalik & Schmidt (2016). The change from the regularized negative binomial regression is trivial, and I opened this PR to start thinking about how modular the implementation needs to be.
Closes #12, and we should aim to close #11 as well.
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.