Add closed-form posterior for Gamma-Exponential observation model #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to be failing - not sure what needs to be updated |
|
I had a look, and it's a result of #1512 coupled with erroring on Aesara warnings. Specifically, the first lookup fails, and In normal circumstances, it appears that this warning is muted whenever this import occurs via Aesara, although I don't know by what mechanism. Nevertheless it still trips the pytest warnings filter. Perhaps @brandonwillard has more context and a suggestion for how to tackle this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48
This PR provides a closed-form posterior solution to an Exponential observation model with a Gamma prior.
Some part was directly inspired from other rewrites and tests, but it would be nice to ultimately get to #125