Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Inverse CDF dispatch functions #147

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

ricardoV94
Copy link
Contributor

No description provided.

@ricardoV94
Copy link
Contributor Author

Latest Aesara release is causing tests/test_scan.py::test_initial_values to fail:
https://github.com/aesara-devs/aeppl/runs/6918324742?check_suite_focus=true

@brandonwillard brandonwillard added the enhancement New feature or request label Jun 20, 2022
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating an issue for that unrelated, failing test, we can mark the test as xfail in this PR.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #147 (95e1cb8) into main (8f65562) will decrease coverage by 0.10%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   94.88%   94.78%   -0.11%     
==========================================
  Files          12       12              
  Lines        1780     1802      +22     
  Branches      263      264       +1     
==========================================
+ Hits         1689     1708      +19     
- Misses         51       53       +2     
- Partials       40       41       +1     
Impacted Files Coverage Δ
aeppl/logprob.py 98.02% <86.36%> (-0.78%) ⬇️
aeppl/truncation.py 98.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor updates; otherwise, this looks good.

aeppl/logprob.py Outdated Show resolved Hide resolved
aeppl/logprob.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 merged commit c2b9746 into aesara-devs:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants