Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc/ from sdist #1397

Closed
maresb opened this issue Jan 17, 2023 · 0 comments · Fixed by #1408
Closed

Remove doc/ from sdist #1397

maresb opened this issue Jan 17, 2023 · 0 comments · Fixed by #1408
Labels
help wanted Extra attention is needed refactor This issue involves refactoring setup and installation Relates to the setup and installation of Aesara

Comments

@maresb
Copy link
Contributor

maresb commented Jan 17, 2023

According to #1384 (comment) it seems that the docs/ directory isn't doing anything but taking up space from the sdist. (Deleting reduces the .tar.gz sdist from 3.85MB to 1.34MB.)

@brandonwillard brandonwillard added refactor This issue involves refactoring setup and installation Relates to the setup and installation of Aesara help wanted Extra attention is needed labels Jan 17, 2023
@maresb maresb changed the title Remove docs/ from sdist Remove doc/ from sdist Feb 5, 2023
maresb added a commit to maresb/aesara that referenced this issue Feb 5, 2023
It seems that the doc/ directory isn't doing anything but taking
up space in the sdist. (Deleting reduces the .tar.gz sdist from 3.85MB
to 1.34MB.)

Note: doc/.build/PLACEHOLDER is still included. It's 14 years old now,
so perhaps it is unnecessary and can be deleted?

Closes aesara-devs#1397
@maresb maresb mentioned this issue Feb 5, 2023
6 tasks
maresb added a commit to maresb/aesara that referenced this issue Feb 18, 2023
It seems that the doc/ directory isn't doing anything but taking
up space in the sdist. (Deleting reduces the .tar.gz sdist from 3.85MB
to 1.34MB.)

Note: doc/.build/PLACEHOLDER is still included. It's 14 years old now,
so perhaps it is unnecessary and can be deleted?

Closes aesara-devs#1397
brandonwillard pushed a commit that referenced this issue Feb 19, 2023
It seems that the doc/ directory isn't doing anything but taking
up space in the sdist. (Deleting reduces the .tar.gz sdist from 3.85MB
to 1.34MB.)

Note: doc/.build/PLACEHOLDER is still included. It's 14 years old now,
so perhaps it is unnecessary and can be deleted?

Closes #1397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactor This issue involves refactoring setup and installation Relates to the setup and installation of Aesara
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants