Enforce sane test values #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
enforce-sane-test-values
branch
from
c169388
to
21daf4e
Compare
This test simply loaded an old example of pickled data. It was both extremely indirect and brittle. Changes to the code base will eventually invalidate nearly all of the old classes used, and whatever the exact issue was, it should've been tested directly.
brandonwillard
force-pushed
the
enforce-sane-test-values
branch
from
bfebf2e
to
746b85f
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Scratchpadclass that validates the values assigned to it, and this new class is used to check that test values have the correct type as soon as they're set.Closes #109.