Split aesara.tensor.rewriting.basic rewrites by their aesara.tensor modules
#1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
graph rewriting
refactor
brandonwillard
force-pushed
the
refactor-rewriting-basic
branch
6 times, most recently
from
937dcf5
to
6370b4e
Compare
brandonwillard
force-pushed
the
refactor-rewriting-basic
branch
from
6370b4e
to
6233cf4
Compare
|
Refactoring much appreciated, it makes the codebase breathe a little more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves rewrite code corresponding to distinct
aesara.tensormodules into their own modules (e.g. shape rewrites are moved toaesara.tensor.rewriting.shape, etc.)These changes should prevent us from creating a giant
aesara.tensor.rewriting.basicfile as we expand rewrite coverage for shapes,Elemwise/CAReducefusing, and so on. It should also make it much easier for people to see and/or find all the relevant rewrites for a given subject.