Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate input names in Numba's Scan transpilation #1198

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Sep 20, 2022

This PR fixes the issue seen in #1176 when several elements of output_infos are None. The example in the issue now works, but I feel that we are just making up for the underlying issue explained in #1176.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1198 (53744c9) into main (cd3a3ce) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1198   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files         173      173           
  Lines       48471    48471           
  Branches    10963    10963           
=======================================
  Hits        38361    38361           
  Misses       7607     7607           
  Partials     2503     2503           
Impacted Files Coverage Δ
aesara/link/numba/dispatch/scan.py 95.55% <100.00%> (ø)

@brandonwillard brandonwillard changed the title Deduplicate nit-sots variable names before Numba transpilation Avoid duplicate input names in Numba's Scan transpilation Sep 20, 2022
@brandonwillard brandonwillard merged commit 0d69809 into aesara-devs:main Sep 21, 2022
@brandonwillard brandonwillard added bug Something isn't working Scan Involves the `Scan` `Op` Numba Involves Numba transpilation labels Sep 21, 2022
@rlouf
Copy link
Member Author

rlouf commented Sep 23, 2022

I see there's a unique_name_generator function in aesara.link.utils, is that its purpose?

@brandonwillard
Copy link
Member

I see there's a unique_name_generator function in aesara.link.utils, is that its purpose?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Numba Involves Numba transpilation Scan Involves the `Scan` `Op`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numba Scan fails when multiple None values are passed in outputs_info
2 participants