Fix storage and mit-mot handling in numba_funcify_Scan
#1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
bug
brandonwillard
force-pushed
the
refactor-Numba-Scan
branch
2 times, most recently
from
34d8080
to
fd03bd5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
========================================
Coverage 79.13% 79.14%
========================================
Files 173 173
Lines 48492 48523 +31
Branches 10966 10319 -647
========================================
+ Hits 38374 38403 +29
- Misses 7625 7628 +3
+ Partials 2493 2492 -1
|
|
While working on this, I noticed some inner-function typing issues that—again—involve the distinction between NumPy and Numba scalars (cf. #1063). More specifically, an inner-function could return a Numba scalar for a tap with storage that is typed as a NumPy scalar. If I can find a reasonable general solution soon, then I'll include it in this PR; otherwise, we can merge this and handle that issue separately. |
brandonwillard
force-pushed
the
refactor-Numba-Scan
branch
7 times, most recently
from
ae3ef98
to
d3703b2
Compare
brandonwillard
force-pushed
the
refactor-Numba-Scan
branch
6 times, most recently
from
c2aadda
to
f2c509f
Compare
This should prevent errors when the input is already a Numba scalar, and it will use Numba's type information to selectively apply the scalar conversion.
Using the `auto_name` values will result in cache misses when caching is based on the generated source code, so we're not going to use it.
brandonwillard
force-pushed
the
refactor-Numba-Scan
branch
from
f2c509f
to
aefeeef
Compare
brandonwillard
changed the title
numba_funcify_Scannumba_funcify_Scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some storage allocation and access/usage issues in
numba_funcify_Scan.Closes #923
Scaninput storage support