Add support for shared inputs in numba_funcify_Scan
#1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
Numba
brandonwillard
force-pushed
the
add-Numba-Scan-shared-inputs
branch
2 times, most recently
from
ffd9ff7
to
1cf82f7
Compare
brandonwillard
force-pushed
the
add-Numba-Scan-shared-inputs
branch
from
1cf82f7
to
e1ad0f1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
=======================================
Coverage 79.14% 79.15%
=======================================
Files 173 173
Lines 48528 48536 +8
Branches 10322 10322
=======================================
+ Hits 38408 38417 +9
Misses 7628 7628
+ Partials 2492 2491 -1
|
brandonwillard
force-pushed
the
add-Numba-Scan-shared-inputs
branch
from
e1ad0f1
to
b386966
Compare
brandonwillard
force-pushed
the
add-Numba-Scan-shared-inputs
branch
from
b386966
to
bc73460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing shared input support to
numba_funcify_Scanand fixes aTypecheck bug inmake_numba_random_fn.