Use Numba's Generator support
#1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
important
Numba
This comment was marked as resolved.
This comment was marked as resolved.
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
from
8b03ded
to
da9f069
Compare
ricardoV94
reviewed
Oct 9, 2022
ricardoV94
reviewed
Oct 9, 2022
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
14 times, most recently
from
c111b34
to
f7b5dca
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
=======================================
Coverage 74.12% 74.12%
=======================================
Files 174 174
Lines 48654 48654
Branches 10353 10353
=======================================
Hits 36064 36064
Misses 10300 10300
Partials 2290 2290 |
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
2 times, most recently
from
68c1716
to
40fa538
Compare
|
OK, this should be good merge once the Numba 0.57 RC release is created containing all the |
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
from
40fa538
to
3bb1dca
Compare
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
from
3bb1dca
to
77c077a
Compare
2 tasks
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
from
77c077a
to
31b77a2
Compare
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
from
8a83740
to
9304396
Compare
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
4 times, most recently
from
c608e10
to
61bd864
Compare
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
2 times, most recently
from
450f759
to
611077f
Compare
|
The current failure will be fixed by #1496. |
brandonwillard
force-pushed
the
enable-Numba-Generators
branch
from
611077f
to
4d1c477
Compare
Smit-create
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #814.
dirichletisn't currently supported in Numba.gumbelisn't currently supported in Numba.binomialisn't currently supported in Numba.Object-mode is being used. This will need a follow-up issue for a non-object-mode implementation.
hypergeometricisn't currently supported in Numba.Object-mode is being used. This will need a follow-up issue for a non-object-mode implementation.
scanruns performed without merging produce slightly different sample results between Numba and Python modes.This might be due to the extra RNG state
copys in the PythonRandomVariable.performimplementations, but I haven't checked yet.Update: It was due to the
copys, and they've been added to the Numba implementations; however, they require the use of object-mode, which is somewhat undesirable. This will need a follow-up issue for a non-object-mode implementation.