Refactor output Type inference in RandomVariable and Scan
#1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-RandomVariable-shape-inference
branch
from
d3bd279
to
67bd9e0
Compare
brandonwillard
changed the title
Elemwise.grad and RandomVariable.make_node deprecated TensorType.broadcastable usageTensorType.broadcastable usage in Elemwise.grad and RandomVariable.make_node
brandonwillard
force-pushed
the
fix-RandomVariable-shape-inference
branch
2 times, most recently
from
8c27dd3
to
d2a61ba
Compare
This comment was marked as outdated.
This comment was marked as outdated.
brandonwillard
force-pushed
the
fix-RandomVariable-shape-inference
branch
from
d2a61ba
to
9b7021c
Compare
3 tasks
brandonwillard
changed the title
TensorType.broadcastable usage in Elemwise.grad and RandomVariable.make_node Type inference in RandomVariable.make_node
brandonwillard
force-pushed
the
fix-RandomVariable-shape-inference
branch
2 times, most recently
from
c52fa95
to
194ef41
Compare
|
Looks like this required some long overdue updates to the use of |
brandonwillard
force-pushed
the
fix-RandomVariable-shape-inference
branch
from
194ef41
to
6423330
Compare
brandonwillard
force-pushed
the
fix-RandomVariable-shape-inference
branch
from
6423330
to
272880e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 78.35% 74.10% -4.25%
==========================================
Files 152 174 +22
Lines 47685 48624 +939
Branches 10881 10351 -530
==========================================
- Hits 37364 36035 -1329
- Misses 7773 10301 +2528
+ Partials 2548 2288 -260
|
brandonwillard
changed the title
Type inference in RandomVariable.make_node Type inference in RandomVariable and Scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides initial fixes for #1252, and similar faulty logic that's based on the deprecated strict
TensorType.broadcastable.