Add documentation for contributing to Aesara #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONTRIBUTING.md
Outdated
Comment on lines
22
to
23
| Our technical scope and project governance may open up later, of course, | ||
| especially after we release version 1.0. For now, though, we would characterize |
There was a problem hiding this comment.
Suggested change
| Our technical scope and project governance may open up later, of course, | |
| especially after we release version 1.0. For now, though, we would characterize | |
| Our technical scope and project governance may open up later, of course. For now, though, we would characterize |
brandonwillard
previously approved these changes
Nov 3, 2022
rlouf
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Looks great! Two comments on the content:
- How about removing the section about moving PRs from Theano? I think this is neither necessary, nor desirable at this point.
- We should add a comment about what we think issues are about (stuff that someone can pick up and work on immediately) and when to open a discussion instead. Insist on MWE and the fact that they need to be implemented with Aesara directly.
dgerlanc
force-pushed
the
update-contributing
branch
from
bdf4568
to
9d89f76
Compare
- Add "Contribution Expectations" and "Issues and Discussions" sections - Remove section on migrating PRs from Theano
dgerlanc
force-pushed
the
update-contributing
branch
from
9d89f76
to
9773227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "Contributing" section in the
README.rstand updateCONTRIBUTING.md