-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace some uses of TensorType.broadcastable
with TensorType.shape
#1297
Merged
brandonwillard
merged 12 commits into
aesara-devs:main
from
brandonwillard:replace-broadcastable-with-shape
Nov 15, 2022
Merged
Replace some uses of TensorType.broadcastable
with TensorType.shape
#1297
brandonwillard
merged 12 commits into
aesara-devs:main
from
brandonwillard:replace-broadcastable-with-shape
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
brandonwillard
changed the title
Replace use of
Replace some uses of Nov 14, 2022
TensorType.broadcastable
with TensorType.shape
TensorType.broadcastable
with TensorType.shape
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
==========================================
- Coverage 74.12% 74.11% -0.01%
==========================================
Files 174 174
Lines 48654 48673 +19
Branches 10353 10379 +26
==========================================
+ Hits 36064 36076 +12
- Misses 10300 10305 +5
- Partials 2290 2292 +2
|
brandonwillard
force-pushed
the
replace-broadcastable-with-shape
branch
from
November 15, 2022 19:27
4a8ea3d
to
75274ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains important and independent
TensorType.shape
refactoring from #1280. Aside from superficialTensorType.broadcastable
-to-TensorType.shape
refactoring, these changes contain improvements to our staticType
-level shape inference capabilities.