Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some uses of TensorType.broadcastable with TensorType.shape #1297

Merged

Conversation

brandonwillard
Copy link
Member

This PR contains important and independent TensorType.shape refactoring from #1280. Aside from superficial TensorType.broadcastable-to-TensorType.shape refactoring, these changes contain improvements to our static Type-level shape inference capabilities.

@brandonwillard brandonwillard changed the title Replace use of TensorType.broadcastable with TensorType.shape Replace some uses of TensorType.broadcastable with TensorType.shape Nov 14, 2022
@brandonwillard brandonwillard self-assigned this Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1297 (4a8ea3d) into main (eace7f6) will decrease coverage by 0.00%.
The diff coverage is 85.19%.

❗ Current head 4a8ea3d differs from pull request most recent head 75274ef. Consider uploading reports for the commit 75274ef to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   74.12%   74.11%   -0.01%     
==========================================
  Files         174      174              
  Lines       48654    48673      +19     
  Branches    10353    10379      +26     
==========================================
+ Hits        36064    36076      +12     
- Misses      10300    10305       +5     
- Partials     2290     2292       +2     
Impacted Files Coverage Δ
aesara/compile/debugmode.py 60.45% <0.00%> (ø)
aesara/link/c/params_type.py 80.41% <ø> (ø)
aesara/tensor/fourier.py 60.81% <0.00%> (ø)
aesara/tensor/nnet/corr.py 16.81% <0.00%> (ø)
aesara/tensor/nnet/corr3d.py 17.26% <0.00%> (ø)
aesara/tensor/rewriting/basic.py 92.12% <ø> (ø)
aesara/tensor/signal/pool.py 28.30% <50.00%> (ø)
aesara/sparse/sandbox/sp.py 73.48% <66.66%> (ø)
aesara/tensor/elemwise.py 88.59% <75.00%> (-0.15%) ⬇️
aesara/tensor/nnet/abstract_conv.py 18.80% <81.81%> (+0.18%) ⬆️
... and 27 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant