Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant graph_inputs usage in OpFromGraph #1306

Merged
merged 3 commits into from
Nov 20, 2022

Conversation

brandonwillard
Copy link
Member

This PR removes a redundant walk through the graph.

There are a few more important improvements needed in the OpFromGraph constructor. I may add them here.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #1306 (9965035) into main (5aa1780) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   74.10%   74.10%   -0.01%     
==========================================
  Files         174      174              
  Lines       48681    48673       -8     
  Branches    10379    10373       -6     
==========================================
- Hits        36074    36067       -7     
- Misses      10313    10315       +2     
+ Partials     2294     2291       -3     
Impacted Files Coverage Δ
aesara/compile/builders.py 77.05% <100.00%> (+0.34%) ⬆️
aesara/scan/op.py 85.13% <100.00%> (+0.06%) ⬆️
aesara/graph/basic.py 87.66% <0.00%> (-0.88%) ⬇️
aesara/graph/fg.py 88.53% <0.00%> (+1.14%) ⬆️

@brandonwillard brandonwillard added enhancement New feature or request refactor This issue involves refactoring performance concern labels Nov 20, 2022
@brandonwillard brandonwillard merged commit 14c394d into aesara-devs:main Nov 20, 2022
@brandonwillard brandonwillard deleted the OpFromGraph-updates branch November 20, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance concern refactor This issue involves refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant